mppx-condition-gate: Free-access path grants on a self-declared wallet without proving control

QFinch assessment

Both packages wrap an `mppx` payment method so that a wallet meeting on-chain conditions is granted free access instead of being charged.

Potential impact

Both packages wrap an mppx payment method so that a wallet meeting on-chain conditions is granted free access instead of being charged. The free-access path reads the payer address from credential.source — a client-supplied DID in the payment credential — asks InsumerAPI whether that address satisfies the configured conditions, and on a pass returns a successful receipt without ever calling the wrapped payment verifier. Nothing in that path establishes that the caller controls the wallet it named. Because qualifying wallets are public chain state, an attacker does not need to guess one. Naming any qualifying address in credential.source is sufficient to obtain free access to a route that should have been paid for. An in-process cache (default TTL 300s, keyed on wallet and conditions) then re-serves the grant without re-evaluating. mppx documents this requirement explicitly. Its type definitions describe source as "an asserted identity, not independent proof of control", and state that methods relying on it "must validate the relationship to the credential payload". These packages did not. This is a defect in these wrapper packages, not in the attestation they consume. The attestation answers one question — does this wallet satisfy these conditions — and answered it honestly about the address it was given. Binding that address to the caller was the wrapper's responsibility.